using standard error code to replace terror #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Aug 25, 2020
terror/terror.go
Outdated
Comment on lines
143
to
147
| var rfcCode = fmt.Sprintf("%s:%d", errClass2Desc[ec], code) | ||
| err := errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(rfcCode)) | ||
| errCodeMap[code] = err | ||
| tags := strings.Split(rfcCode, ":") | ||
| class := tags[0] |
There was a problem hiding this comment.
Suggested change
| var rfcCode = fmt.Sprintf("%s:%d", errClass2Desc[ec], code) | |
| err := errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(rfcCode)) | |
| errCodeMap[code] = err | |
| tags := strings.Split(rfcCode, ":") | |
| class := tags[0] | |
| class := errClass2Desc[ec] | |
| rfcCode := fmt.Sprintf("%s:%d", class, code) | |
| err := errors.Normalize(message, errors.MySQLErrorCode(int(code)), errors.RFCCodeText(rfcCode)) | |
| errCodeMap[code] = err |
lonng
reviewed
Aug 25, 2020
lonng
reviewed
Aug 25, 2020
lonng
reviewed
Aug 25, 2020
|
PTAL @kennytm |
added 11 commits
September 8, 2020 14:21
lysu
approved these changes
Sep 8, 2020
ti-srebot
approved these changes
Sep 8, 2020
|
cherry pick to release-4.0 failed |
imtbkcat
pushed a commit
to imtbkcat/parser
that referenced
this pull request
Sep 8, 2020
imtbkcat
pushed a commit
that referenced
this pull request
Sep 8, 2020
imtbkcat
pushed a commit
that referenced
this pull request
Sep 11, 2020
imtbkcat
pushed a commit
that referenced
this pull request
Sep 11, 2020
imtbkcat
pushed a commit
to imtbkcat/parser
that referenced
this pull request
Sep 18, 2020
This was referenced Sep 18, 2020
imtbkcat
pushed a commit
that referenced
this pull request
Sep 21, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
According to RFC, TiDB need to adjust error format and using standard error to replace terror. The standard error has been implemented in https://github.com/pingcap/errors/tree/standard-error
What is changed and how it works?
Since standard error is very similar with
terror. We can change very few api to replace theterror. Just renameterror.Errorwitherrors.ErrorCheck List
Tests
Code changes
Side effects
Related changes