Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using standard error code to replace terror (#982) #1014

Merged
merged 1 commit into from
Sep 8, 2020
Merged

using standard error code to replace terror (#982) #1014

merged 1 commit into from
Sep 8, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Sep 8, 2020 •
edited
Loading

What problem does this PR solve?

cherry-pick #982 to release-4.0

According to RFC, TiDB need to adjust error format and using standard error to replace terror. The standard error has been implemented in https://github.com/pingcap/errors/tree/standard-error

What is changed and how it works?

Since standard error is very similar with terror. We can change very few api to replace the terror. Just rename terror.Error with errors.Error

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • None

@imtbkcat imtbkcat mentioned this pull request Sep 8, 2020
Merged
bobotu
bobotu approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@bobotu bobotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@bobotu,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack).

@lonng
Copy link
Contributor

lonng commented Sep 8, 2020

LGTM

@ti-srebot
Copy link
Contributor

@lonng,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack).

@imtbkcat imtbkcat merged commit b65348b into pingcap:release-4.0 Sep 8, 2020
imtbkcat pushed a commit that referenced this pull request Sep 11, 2020
Revert "using standard error code to replace terror (#982) (#1014)"
87d3dd7 
This reverts commit b65348b.
@imtbkcat imtbkcat mentioned this pull request Sep 11, 2020
Merged
imtbkcat pushed a commit that referenced this pull request Sep 11, 2020
Revert "using standard error code to replace terror (#982) (#1014)" (#…
2582971 
…1019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobotu bobotu bobotu approved these changes

@kennytm kennytm Awaiting requested review from kennytm

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
type/cherry-pick-for-release-4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @ti-srebot @lonng @bobotu