server, client: fix hanging problem when etcd failed to start #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
added
the
needs-cherry-pick-release-2.1
|
/run-all-tests |
nolouch
approved these changes
Oct 11, 2018
rleungx
approved these changes
Oct 11, 2018
This was referenced Oct 15, 2018
disksing
added a commit
to oh-my-tidb/pd
that referenced
this pull request
Oct 23, 2018
nolouch
pushed a commit
that referenced
this pull request
Oct 23, 2018
nolouch
added
the
needs-cherry-pick-release-2.0
disksing
added a commit
to oh-my-tidb/pd
that referenced
this pull request
Nov 14, 2018
disksing
added a commit
that referenced
this pull request
Nov 14, 2018
* server, client: fix hanging problem when etcd failed to start (#1267) * server: use same initialcluster config to restart joined member (#1279) * fix server build * pdctl: cherry pick bugfixes (#1298, #1299, #1308) * server/api: fix the issue about `regions/check` API (#1311) * fix join build * fix pdctl build * fix region test * fix warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Sometimes etcd may get stuck inside when it starts up. At this point, the port of the PD is in listened, but it cannot serve any requests. At the same time, the client (tidb) will also get stuck because the pd-server does not return a message.
What is changed and how it works?
Add context timeout in 2 places:
startEtcd. If etcd is not able to start in time, pd-server will report an error and exit.initClusterID. If pd server not responds, the client will query next pd server instance.TODO: update tidb vendor.
Check List
Tests
Related changes