server.go: refine log when not in online state (#688)

as expected to write fails, make it not a tedious error log
pingcap · Jul 25, 2019 · 1a2bba3 · 1a2bba3
1 parent 47163d0
commit 1a2bba3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pump/server.go b/pump/server.go
@@ -233,7 +233,11 @@ func (s *Server) writeBinlog(ctx context.Context, in *binlog.WriteBinlogReq, isF
 
 errHandle:
 	lossBinlogCacheCounter.Add(1)
-	log.Error("write binlog failed", zap.Error(err))
+	if strings.HasPrefix(err.Error(), "no online") {
+		log.Warn("reject write binlog for not online state", zap.String("state", s.node.NodeStatus().State))
+	} else {
+		log.Error("write binlog failed", zap.Error(err))
+	}
 	ret.Errmsg = err.Error()
 	return ret, err
 }