-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drainer: fix filter skip checkpoint problem #1069
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
/rebuild |
should this be cherry-picked to 4.0, 5.0, 5.1, 5.2? |
Yes |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 547443f
|
/run-all-tests |
In response to a cherrypick label: new pull request created: #1073. |
In response to a cherrypick label: new pull request created: #1074. |
In response to a cherrypick label: new pull request created: #1075. |
In response to a cherrypick label: new pull request created: #1076. |
What problem does this PR solve?
If we continuously write TiDB but filter most tables, drainer's checkpoint tso won't update in a long time has some bad effects:
What is changed and how it works?
Rewrite filtered binlogs to fake binlogs (commit ts = filtered binlog's commit ts) and send to drainer.
To avoid too many fake binlogs, we only re-generate fake binlogs after AT LEAST 3 SECONDS.
Check List
Tests
Code changes
Side effects
Related changes
Release note