vlog.go: Fix wrongly maintain the offset of file in memory #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the write file but may successfully write some part of data but we don's add the offset that we maintain, later successfully write request will get a wrong offset. Add a test minic test case by mount a specify space tmpfs, but currently only can run in linux platform(no tmpfs in mac), and need root privilege.
|
/run-unit-test |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
kennytm
reviewed
Jun 19, 2019
csuzhangxc
reviewed
Jun 19, 2019
|
/run-all-tests |
suzaku
reviewed
Jun 20, 2019
csuzhangxc
approved these changes
Jun 20, 2019
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Jun 20, 2019
When the write file but may successfully write some part of data but we don's added the offset that we maintain, later successfully write request will get a wrong offset. Add a test when no disk space fail to write and should recover after disk space are free up set file size resource limit to make it write fail like no disk space
july2993
added a commit
that referenced
this pull request
Jun 20, 2019
When the write file but may successfully write some part of data but we don's added the offset that we maintain, later successfully write request will get a wrong offset. Add a test when no disk space fail to write and should recover after disk space are free up set file size resource limit to make it write fail like no disk space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix wrongly maintain the offset of file in memory
What is changed and how it works?
When the write fails but may successfully write some part of data
but we don't added the offset that we maintain, later successfully
write request will get a wrong offset.
Add a test mimic test case by mount a specify space tmpfs, butcurrently only can run in linux platform(no tmpfs in mac), and
need root privilege.
Add a test when no disk space fail to write and should recover after disk space are free up
set file size resource limit to make it write fail like no disk space
Check List
Tests
Code changes
Side effects
Related changes