Fix ui test of ci #752
Fix ui test of ci #752
Conversation
|
Get |
|
TiDB v4.0.5 works fine, so it can be confirmed the root cause is pingcap/tidb#19731 . Should we use the stable TiDB instead of the nightly version? @breeswish |
| await ppExpect(page).toMatch('TiDB authentication failed') | ||
|
|
||
| const failReason = await page.waitForSelector( | ||
| 'form#tidb_signin div[data-e2e="password"] div:last-child' |
There was a problem hiding this comment.
This div:last-child is too magical.. Can we await for pages to contain some string?
There was a problem hiding this comment.
It seems no way to add the extra flag to the error message self except to its parent container likes data-e2e="password".
There was a problem hiding this comment.
Or we can simply remove the div:last-child.
There was a problem hiding this comment.
Just got what you mean. I print the failed reason content to help debug what the exact failed reason. It may not be "TiDB authentication failed", it may "Failed to connect to TiDB" etc. So when the UI test fails later, I can know what makes it fail.
* misc: Increase ulimit to 65535 for test env (#756) * test: Fix frontend CI (#752) * ui: fix dayjs i18n (#755) * ui: handle error globally (#757) * statement, slow_query: support all fields in list page (#749) * ui: memorize expand/collapse full text in detail pages (#775) * ui: break loop dependencies (#771) * ui: fix browser compatibility check (#776) * ui: Refine store location, add zoom and pan (#772) * ui: show disk usage information for statement and slow query (#777) * ui: use qps instead of ops (#786) * statement: support export (#778) *: Fix slow query and start_ts not working in some cases (#793) * ui: fix errors doesn't display (#794) * ui: fix the error message doesn't show correct (#799) * slow_queries: support export (#792) * ui: add MySqlFormatter to customize the sql formatter (#805) *: fix query statement detail error cause by round (#806) * ui: copy original content instead of formatted content for CopyLink (#802) * add min height of topology canvas (#804) * metrics: Support customize Prometheus address (#808) * clusterinfo: Refine (#815) * ui: Open statement and slow log in new tab (#816) * ui: add more time field for slow query detail page (#810) * slowlog: Improve descriptions (#817) * build: add action to check release-version is changed for release branch * Release v2020.11.26.1
No description provided.