Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Open statement and slow log in new tab #816

Merged
merged 1 commit into from Nov 26, 2020
Merged

ui: Open statement and slow log in new tab #816

merged 1 commit into from Nov 26, 2020

Conversation

breezewish
Copy link
Member

This is a workaround for #641 to improve UX without changing too many codebase.

However most ideally we should implement page memorization and bring back "Back" again.

Also fixes #796

Signed-off-by: Breezewish me@breeswish.org

Signed-off-by: Breezewish <me@breeswish.org>
@breezewish breezewish changed the title Open statement and slow log in new tab ui: Open statement and slow log in new tab Nov 26, 2020
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baurine
Copy link
Collaborator

baurine commented Nov 26, 2020

Maybe later we can try to use use-swr to help cache the API response.

@breezewish breezewish merged commit 7e67709 into master Nov 26, 2020
@breezewish breezewish deleted the new_tab branch November 26, 2020 09:09
breezewish added a commit that referenced this pull request Nov 26, 2020
Signed-off-by: Breezewish <me@breeswish.org>
breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
@unbyte
Copy link
Contributor

unbyte commented Dec 2, 2020

how about using react-activation?

@breezewish
Copy link
Member Author

how about using react-activation?

Feel free to dig it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the query spinner more visible
4 participants