Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

config,mydumper: replace black-white-list by table-filter #332

Merged
merged 5 commits into from Jun 24, 2020
Merged

config,mydumper: replace black-white-list by table-filter #332

merged 5 commits into from Jun 24, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Jun 16, 2020

What problem does this PR solve?

Deprecate the existing [black-white-list] feature, replace it by the new table-filter.

What is changed and how it works?

Check List

Tests

  • Integration test

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

Release Notes

  • [black-white-list] has been deprecated with a newer, easier-to-understand filter format.

@kennytm kennytm added the status/WIP Work in progress label Jun 16, 2020
@kennytm kennytm force-pushed the kennytm/deprecate-black-white-list branch 4 times, most recently from f333f5a to 46c6e58 Compare June 16, 2020 18:26
@kennytm kennytm force-pushed the kennytm/deprecate-black-white-list branch 2 times, most recently from 8529b72 to da1c000 Compare June 17, 2020 20:56
@kennytm kennytm force-pushed the kennytm/deprecate-black-white-list branch from da1c000 to 4bdd402 Compare June 17, 2020 21:03
@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP Work in progress labels Jun 17, 2020
@kennytm kennytm requested a review from 3pointer June 18, 2020 07:51
3pointer
3pointer reviewed Jun 19, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw, when to remove old black-white-list

@kennytm
Copy link
Collaborator Author

kennytm commented Jun 19, 2020

Preferably never.

@kennytm kennytm added 3.0-release-note Should include in release note for next 3.0 release. Remove after release. 3.1-release-note Should include in release note for next 3.1 release. Remove after release. 4.0-release-note Should include in release note for next 4.0 release. Remove after release. Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 19, 2020
overvenus
overvenus previously approved these changes Jun 21, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Jun 21, 2020
@kennytm kennytm requested a review from 3pointer June 22, 2020 16:57
3pointer
3pointer approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL IANTHEREAL merged commit cd6210d into master Jun 24, 2020
@IANTHEREAL IANTHEREAL deleted the kennytm/deprecate-black-white-list branch June 24, 2020 07:26
@kennytm kennytm mentioned this pull request Jun 29, 2020
Merged
5 tasks
This was referenced Jul 3, 2020
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@3pointer 3pointer 3pointer approved these changes

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@overvenus overvenus overvenus left review comments

Assignees
No one assigned
Labels
3.0-release-note Should include in release note for next 3.0 release. Remove after release. 3.1-release-note Should include in release note for next 3.1 release. Remove after release. 4.0-release-note Should include in release note for next 4.0 release. Remove after release. Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kennytm @overvenus @3pointer @IANTHEREAL