Skip to content

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #3065 to release-4.0


What is changed, added or deleted? (Required)

This PR documented the "table filter" feature shared by all new TiDB ecosystem tools, superseding the old "black-white-list" feature. The documentation is heavily copied from https://github.com/pingcap/tidb-tools/blob/master/pkg/table-filter/README.md.

The feature is / will be available in

  • Lightning (v4.0.2, v3.1.3, v3.0.17)
  • BR (v4.0.0-rc, v3.1.0-rc)
  • Dumpling
  • CDC (v4.0.2)
  • (DM may also switch to this in the future.)

The Lightning docs have been revised for this. The existing "black-white-list" page has been redirected to the shared reference. ("black-white-list" still works but are no longer recommended. Therefore we don't bother to rename these into "block-allow-list")

The BR docs have been expanded to describe -f.

Dumpling is untouched, but whoever translating pingcap/docs-cn#3541 should point the link in --filter to this new document rather than the README.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions) (only BR and Lightning)
  • v3.0 (TiDB 3.0 versions) (only Lightning)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added size/large Changes of a large size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@kennytm please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs/invitations

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@kennytm, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2020
@ti-srebot
Copy link
Contributor Author

@ran-huang,Thanks for your review.

@ran-huang ran-huang merged commit 1ed4c88 into pingcap:release-4.0 Jul 3, 2020
yikeke pushed a commit that referenced this pull request Aug 3, 2020
yikeke added a commit that referenced this pull request Aug 3, 2020
* fix #3098 and delete key-features.md

* fix #3080 and delete tiflash-faq.md

* fix #3140 and delete tidb-lightning-table-filter.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants