This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
backend/local: skip split regions if engine total size is smaller than region size #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Dec 15, 2020
|
/run-all-tests |
lance6716
reviewed
Jan 11, 2021
lightning/backend/local.go
Outdated
| @@ -1181,10 +1181,14 @@ func (local *local) ImportEngine(ctx context.Context, engineUUID uuid.UUID) erro | |||
| log.L().Info("start import engine", zap.Stringer("uuid", engineUUID), | |||
| zap.Int("ranges", len(ranges))) | |||
|
|
|||
| // if all the kv can fit in one region, skip split regions. TiDB will split one region for | |||
| // the table when table is created. | |||
| needSplit := len(ranges) > 0 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount | |||
There was a problem hiding this comment.
is needSplit := len(ranges) > 1 enough? seems readAndSplitIntoRange has checked regionSplitSize and regionMaxKeyCount
tidb-lightning/lightning/backend/local.go
Lines 811 to 815 in d9254b1
and splitRangeBySizeProps uses a tighter keysLimit so it will return more than 1 ranges
There was a problem hiding this comment.
splitRangeBySizeProps may still generate ranges that exceed regionSplitSize, so if the split is triggered by remain ranges, it may be a single range but the range size is exceeded.
There was a problem hiding this comment.
I see. Now I suggest
Suggested change
| needSplit := len(ranges) > 0 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount | |
| needSplit := len(ranges) > 1 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount |
lance6716
reviewed
Jan 11, 2021
lightning/backend/local.go
Outdated
| @@ -1181,10 +1181,14 @@ func (local *local) ImportEngine(ctx context.Context, engineUUID uuid.UUID) erro | |||
| log.L().Info("start import engine", zap.Stringer("uuid", engineUUID), | |||
| zap.Int("ranges", len(ranges))) | |||
|
|
|||
| // if all the kv can fit in one region, skip split regions. TiDB will split one region for | |||
| // the table when table is created. | |||
| needSplit := len(ranges) > 0 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount | |||
There was a problem hiding this comment.
I see. Now I suggest
Suggested change
| needSplit := len(ranges) > 0 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount | |
| needSplit := len(ranges) > 1 || lf.TotalSize > local.regionSplitSize || lf.Length > regionMaxKeyCount |
|
LGTM |
ti-srebot
approved these changes
Jan 11, 2021
ti-srebot
added
the
status/LGT2
|
/merge |
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Skip split regions there is only one range within the engine.
What is changed and how it works?
Check List
Tests
Side effects
Related changes