Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete versions into apps/v1 #1012

Merged
merged 24 commits into from Oct 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3083616
removed extensions
Yisaer Oct 14, 2019
ff95dc5
remove v1beta2
Yisaer Oct 14, 2019
9a42afb
remove apps/v1beta1
Yisaer Oct 15, 2019
75f98da
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 15, 2019
080fb74
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 15, 2019
6d7c979
chang go code
Yisaer Oct 15, 2019
c57eab3
fix
Yisaer Oct 15, 2019
e9fff9a
fix
Yisaer Oct 15, 2019
902eeeb
deepcopy gen
Yisaer Oct 15, 2019
d0459bf
Merge branch 'master' into fix_obsolete_versions
Yisaer Oct 16, 2019
456358c
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 16, 2019
e994ae0
Update kind-cluster-build.sh
Yisaer Oct 16, 2019
a05e72b
Merge branch 'master' into fix_obsolete_versions
Yisaer Oct 16, 2019
b95db14
fix conlict
Yisaer Oct 16, 2019
37f62b6
Merge branch 'fix_obsolete_versions' of https://github.com/Yisaer/tid…
Yisaer Oct 16, 2019
e1cf2f4
go mod tidy
Yisaer Oct 17, 2019
d92d990
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 17, 2019
986cf6d
Merge branch 'master' into fix_obsolete_versions
Yisaer Oct 18, 2019
d9c23fa
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 18, 2019
a2e321b
Merge remote-tracking branch 'upstream/master' into fix_obsolete_vers…
Yisaer Oct 18, 2019
71403a3
clean code
Yisaer Oct 18, 2019
0497d08
Merge branch 'master' into fix_obsolete_versions
Yisaer Oct 21, 2019
aee37b5
clean code
Yisaer Oct 21, 2019
d432c97
Merge branch 'master' into fix_obsolete_versions
Yisaer Oct 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/discovery-deployment.yaml
@@ -1,4 +1,4 @@
apiVersion: apps/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "cluster.name" . }}-discovery
Expand Down
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/monitor-deployment.yaml
@@ -1,5 +1,5 @@
{{- if .Values.monitor.create }}
apiVersion: apps/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ template "cluster.name" . }}-monitor
Expand Down
@@ -1,4 +1,4 @@
apiVersion: apps/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: tidb-controller-manager
Expand Down
2 changes: 1 addition & 1 deletion charts/tidb-operator/templates/scheduler-deployment.yaml
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ .Values.scheduler.schedulerName }}
Expand Down
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: local-volume-provisioner
Expand Down
Expand Up @@ -20,7 +20,7 @@ data:
mountDir: /mnt/local-ssd

---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: local-volume-provisioner
Expand Down
4 changes: 2 additions & 2 deletions hack/kind-cluster-build.sh
Expand Up @@ -133,7 +133,7 @@ registryNodeIP=$(kubectl get nodes ${registryNode} -o template --template='{{ran
registryFile=${workDir}/registry.yaml

cat <<EOF >${registryFile}
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: registry
Expand Down Expand Up @@ -164,7 +164,7 @@ spec:
hostPath:
path: /data
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: registry-proxy
Expand Down
2 changes: 1 addition & 1 deletion manifests/gke/local-ssd-optimize.yaml
@@ -1,5 +1,5 @@
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: local-ssd-startup-cos
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/dind-cluster-v1.10.sh
Expand Up @@ -1665,7 +1665,7 @@ data:
}
}
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
labels:
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/dind-cluster-v1.12.sh
Expand Up @@ -1680,7 +1680,7 @@ data:
}
}
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
labels:
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/kube-flannel.yaml
Expand Up @@ -79,7 +79,7 @@ data:
}
}
---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: kube-flannel-ds-amd64
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/kubernetes-dashboard.yaml
Expand Up @@ -41,7 +41,7 @@ subjects:
namespace: kube-system
---
kind: Deployment
apiVersion: extensions/v1beta1
apiVersion: apps/v1
metadata:
labels:
k8s-app: kubernetes-dashboard
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/local-volume-provisioner.yaml
Expand Up @@ -20,7 +20,7 @@ data:
mountDir: /mnt/disks

---
apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: local-volume-provisioner
Expand Down
2 changes: 1 addition & 1 deletion manifests/local-dind/registry-proxy-deployment.yaml
Expand Up @@ -48,7 +48,7 @@ data:

---

apiVersion: extensions/v1beta1
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: registry-proxy
Expand Down
2 changes: 1 addition & 1 deletion manifests/webhook.yaml
Expand Up @@ -105,5 +105,5 @@ webhooks:
rules:
- operations: [ "UPDATE" ]
apiGroups: [ "apps", "" ]
apiVersions: ["v1beta1"]
apiVersions: ["v1"]
resources: ["statefulsets"]
Expand Up @@ -43,9 +43,9 @@ spec:
matchExpressions:
- {key: app.kubernetes.io/name, operator: In, values: [tidb-operator, tidb-cluster, tidb-mp]}
componentKinds:
- group: apps/v1beta2
- group: apps/v1
kind: Deployment
- group: apps/v1beta2
- group: apps/v1
kind: StatefulSet
- group: batch/v1
kind: Job
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/pingcap.com/v1alpha1/tidbcluster_test.go
Expand Up @@ -17,7 +17,7 @@ import (
"testing"

. "github.com/onsi/gomega"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/pingcap.com/v1alpha1/types.go
Expand Up @@ -14,7 +14,7 @@
package v1alpha1

import (
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
Expand Down
16 changes: 8 additions & 8 deletions pkg/apis/pingcap.com/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/controller/controller_utils_test.go
Expand Up @@ -21,7 +21,7 @@ import (

. "github.com/onsi/gomega"
"github.com/pingcap/tidb-operator/pkg/apis/pingcap.com/v1alpha1"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down
12 changes: 6 additions & 6 deletions pkg/controller/stateful_set_control.go
Expand Up @@ -21,13 +21,13 @@ import (
"github.com/pingcap/tidb-operator/pkg/apis/pingcap.com/v1alpha1"
tcinformers "github.com/pingcap/tidb-operator/pkg/client/informers/externalversions/pingcap.com/v1alpha1"
v1listers "github.com/pingcap/tidb-operator/pkg/client/listers/pingcap.com/v1alpha1"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
appsinformers "k8s.io/client-go/informers/apps/v1beta1"
appsinformers "k8s.io/client-go/informers/apps/v1"
"k8s.io/client-go/kubernetes"
appslisters "k8s.io/client-go/listers/apps/v1beta1"
appslisters "k8s.io/client-go/listers/apps/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/retry"
Expand Down Expand Up @@ -56,7 +56,7 @@ func NewRealStatefuSetControl(kubeCli kubernetes.Interface, setLister appslister

// CreateStatefulSet create a StatefulSet in a TidbCluster.
func (sc *realStatefulSetControl) CreateStatefulSet(tc *v1alpha1.TidbCluster, set *apps.StatefulSet) error {
_, err := sc.kubeCli.AppsV1beta1().StatefulSets(tc.Namespace).Create(set)
_, err := sc.kubeCli.AppsV1().StatefulSets(tc.Namespace).Create(set)
// sink already exists errors
if apierrors.IsAlreadyExists(err) {
return err
Expand All @@ -76,7 +76,7 @@ func (sc *realStatefulSetControl) UpdateStatefulSet(tc *v1alpha1.TidbCluster, se
err := retry.RetryOnConflict(retry.DefaultBackoff, func() error {
// TODO: verify if StatefulSet identity(name, namespace, labels) matches TidbCluster
var updateErr error
updatedSS, updateErr = sc.kubeCli.AppsV1beta1().StatefulSets(ns).Update(set)
updatedSS, updateErr = sc.kubeCli.AppsV1().StatefulSets(ns).Update(set)
if updateErr == nil {
glog.Infof("TidbCluster: [%s/%s]'s StatefulSet: [%s/%s] updated successfully", ns, tcName, ns, setName)
return nil
Expand All @@ -99,7 +99,7 @@ func (sc *realStatefulSetControl) UpdateStatefulSet(tc *v1alpha1.TidbCluster, se

// DeleteStatefulSet delete a StatefulSet in a TidbCluster.
func (sc *realStatefulSetControl) DeleteStatefulSet(tc *v1alpha1.TidbCluster, set *apps.StatefulSet) error {
err := sc.kubeCli.AppsV1beta1().StatefulSets(tc.Namespace).Delete(set.Name, nil)
err := sc.kubeCli.AppsV1().StatefulSets(tc.Namespace).Delete(set.Name, nil)
sc.recordStatefulSetEvent("delete", tc, set, err)
return err
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/stateful_set_control_test.go
Expand Up @@ -22,7 +22,7 @@ import (
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/kubernetes/fake"
appslisters "k8s.io/client-go/listers/apps/v1beta1"
appslisters "k8s.io/client-go/listers/apps/v1"
core "k8s.io/client-go/testing"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/tidbcluster/tidb_cluster_control_test.go
Expand Up @@ -25,7 +25,7 @@ import (
"github.com/pingcap/tidb-operator/pkg/controller"
mm "github.com/pingcap/tidb-operator/pkg/manager/member"
"github.com/pingcap/tidb-operator/pkg/manager/meta"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
apiequality "k8s.io/apimachinery/pkg/api/equality"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down
6 changes: 3 additions & 3 deletions pkg/controller/tidbcluster/tidb_cluster_controller.go
Expand Up @@ -27,7 +27,7 @@ import (
mm "github.com/pingcap/tidb-operator/pkg/manager/member"
"github.com/pingcap/tidb-operator/pkg/manager/meta"
"github.com/pingcap/tidb-operator/pkg/pdapi"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -36,7 +36,7 @@ import (
kubeinformers "k8s.io/client-go/informers"
"k8s.io/client-go/kubernetes"
eventv1 "k8s.io/client-go/kubernetes/typed/core/v1"
appslisters "k8s.io/client-go/listers/apps/v1beta1"
appslisters "k8s.io/client-go/listers/apps/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
Expand Down Expand Up @@ -84,7 +84,7 @@ func NewController(
recorder := eventBroadcaster.NewRecorder(v1alpha1.Scheme, corev1.EventSource{Component: "tidbcluster"})

tcInformer := informerFactory.Pingcap().V1alpha1().TidbClusters()
setInformer := kubeInformerFactory.Apps().V1beta1().StatefulSets()
setInformer := kubeInformerFactory.Apps().V1().StatefulSets()
svcInformer := kubeInformerFactory.Core().V1().Services()
epsInformer := kubeInformerFactory.Core().V1().Endpoints()
pvcInformer := kubeInformerFactory.Core().V1().PersistentVolumeClaims()
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/tidbcluster/tidb_cluster_controller_test.go
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/pingcap/tidb-operator/pkg/apis/pingcap.com/v1alpha1"
"github.com/pingcap/tidb-operator/pkg/client/clientset/versioned/fake"
informers "github.com/pingcap/tidb-operator/pkg/client/informers/externalversions"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
Expand Down Expand Up @@ -320,7 +320,7 @@ func newStatefuSet(tc *v1alpha1.TidbCluster) *apps.StatefulSet {
return &apps.StatefulSet{
TypeMeta: metav1.TypeMeta{
Kind: "StatefulSet",
APIVersion: "apps/v1beta1",
APIVersion: "apps/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "test-statefuset",
Expand Down
8 changes: 4 additions & 4 deletions pkg/manager/member/pd_member_manager.go
Expand Up @@ -24,22 +24,22 @@ import (
"github.com/pingcap/tidb-operator/pkg/manager"
"github.com/pingcap/tidb-operator/pkg/pdapi"
"github.com/pingcap/tidb-operator/pkg/util"
apps "k8s.io/api/apps/v1beta1"
apps "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/apimachinery/pkg/util/uuid"
"k8s.io/client-go/listers/apps/v1beta1"
"k8s.io/client-go/listers/apps/v1"
corelisters "k8s.io/client-go/listers/core/v1"
)

type pdMemberManager struct {
pdControl pdapi.PDControlInterface
setControl controller.StatefulSetControlInterface
svcControl controller.ServiceControlInterface
setLister v1beta1.StatefulSetLister
setLister v1.StatefulSetLister
svcLister corelisters.ServiceLister
podLister corelisters.PodLister
epsLister corelisters.EndpointsLister
Expand All @@ -55,7 +55,7 @@ type pdMemberManager struct {
func NewPDMemberManager(pdControl pdapi.PDControlInterface,
setControl controller.StatefulSetControlInterface,
svcControl controller.ServiceControlInterface,
setLister v1beta1.StatefulSetLister,
setLister v1.StatefulSetLister,
svcLister corelisters.ServiceLister,
podLister corelisters.PodLister,
epsLister corelisters.EndpointsLister,
Expand Down