Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete versions into apps/v1 #1012

Merged
merged 24 commits into from Oct 21, 2019

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Oct 15, 2019

What problem does this PR solve?

fix #996
Replacing extensions,apps/v1beta1,apps/v1beta2 into apps/v1 according to kubernetes 1.16 changelog

In statbility test, UpgradeOperator will check wether TiDB cluster would be recreated or not after upgrading TiDB Operator.

What problem does this PR solve?

Fixing api versions which will be obsolete in kubernetes 1.16.

What is changed and how does it work?

Replacing api version.

Tests

  • Manual Test
  • Stability Test

Code changes

  • Has Helm charts change
  • Has go code change

Does this PR introduce a user-facing change?:

Migrating to use app/v1 and does not support Kubernetes before 1.9 anymore.

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 15, 2019

/run-e2e-in-kind

@tennix
Copy link
Member

tennix commented Oct 15, 2019

The Go code using deprecated API group also needs to be updated.

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

4 similar comments
@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

1 similar comment
@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

pkg/manager/member/utils.go Outdated Show resolved Hide resolved
@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 15, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 16, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 16, 2019

/run-e2e-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 16, 2019

/run-e2e-in-kind

@Yisaer Yisaer requested review from tennix and cofyc October 16, 2019 07:16
@Yisaer Yisaer requested review from weekface and cofyc October 17, 2019 05:58
@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 18, 2019

/run-e2e-in-kind

1 similar comment
@cofyc
Copy link
Contributor

cofyc commented Oct 18, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 21, 2019

/run-e2e-in-kind

e2e cluster is being rebuilt just now

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-in-kind

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-test

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer Yisaer merged commit 302f763 into pingcap:master Oct 21, 2019
@Yisaer Yisaer deleted the fix_obsolete_versions branch October 21, 2019 07:30
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

cherry pick to release-1.0 failed

@Yisaer Yisaer restored the fix_obsolete_versions branch October 21, 2019 07:36
Yisaer added a commit that referenced this pull request Oct 21, 2019
* fix yaml

* go code

* fix test
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions API failed to install in Kubernetes 1.16
6 participants