Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually cherry-pick #1012 to release-1.0 #1033

Merged
merged 3 commits into from Oct 21, 2019
Merged

Manually cherry-pick #1012 to release-1.0 #1033

merged 3 commits into from Oct 21, 2019

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Oct 21, 2019

Cherry-pick #1012

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-in-kind

@Yisaer
Copy link
Contributor Author

Yisaer commented Oct 21, 2019

/run-e2e-in-kind

@Yisaer Yisaer requested review from weekface and cofyc October 21, 2019 10:12
weekface
weekface approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer Yisaer changed the title Mannualy cherry-pick #1012 to release-1.0 Manually cherry-pick #1012 to release-1.0 Oct 21, 2019
@Yisaer Yisaer merged commit aa1b022 into pingcap:release-1.0 Oct 21, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang
en: add contents about modify tidb cluster config (#1033)
d95ec14 
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@cofyc cofyc Awaiting requested review from cofyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yisaer @weekface