-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose and set default terraform aliyun ACK version. #1284
Conversation
@shonge Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we can merge it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for 1373 |
/run-all-tests |
What problem does this PR solve?
close #1086
What is changed and how does it work?
Add version to resource "alicloud_cs_managed_kubernetes"
https://github.com/terraform-providers/terraform-provider-alicloud/blob/master/alicloud/resource_alicloud_cs_kubernetes.go#L396-L401
Check List
Tests
Using terraform deploy tidb-operator to aliyun cloud and checking the ACK version.
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: