Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing raw toml config for tiflash (#3355) #3368

Merged
merged 2 commits into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. support passing raw toml config for tiflash (pingcap#3355)

    follow up pingcap#3327
    
    origin way to set config:
    ```yaml
        tiflash:
          baseImage: pingcap/tiflash
          maxFailoverCount: 3
          replicas: 1
          storageClaims:
            - resources:
                requests:
                  storage: 1Gi
    --        # storageClassName: local-storage
          # requests:
          #   storage: "1Gi"
          config:
            config:
              logger:
                level: "warn"
                count: 9
            proxy:
              log-level: "warn"
              gc:
                batch-keys: 501
    ```
    after this pr, support pass config like this:
    ```yaml
        tiflash:
          baseImage: pingcap/tiflash
          maxFailoverCount: 3
          replicas: 1
          storageClaims:
            - resources:
                requests:
                  storage: 1Gi
    --        # storageClassName: local-storage
          # requests:
          #   storage: "1Gi"
          config:
            config: |
              [logger]
                level = "warn"
                count = 9
            proxy: |
              log-level = "warn"
              [gc]
                batch-keys = 501
    ```
    july2993 committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    3307951 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5766944 View commit details
    Browse the repository at this point in the history