New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting customized envs for backup and restore jobs #3833
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3833 +/- ##
==========================================
- Coverage 62.40% 62.38% -0.02%
==========================================
Files 169 169
Lines 17963 17968 +5
==========================================
+ Hits 11209 11210 +1
- Misses 5673 5677 +4
Partials 1081 1081
|
@dragonly could you please add the test result? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9b5a3b4
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-1.1 in PR #3848 |
What problem does this PR solve?
Closes #3831
What is changed and how does it work?
Add
Env
field inBackupSpec
, and add logic/ut cases for backup, restore and clean jobs.Code changes
Tests
Unit test
E2E test
Manual test
spec.env
set.kubectl get job -o yaml
and find that env vars are set correctly, and the builtinGCS_PROJECT_ID
is overwrittenNo code
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.