Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting customized envs for backup and restore jobs (#3833) #3848

Merged
merged 2 commits into from Mar 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 12, 2021

cherry-pick #3833 to release-1.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/3848

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb-operator.git pr/3848:release-1.1-d43d017b69a6

What problem does this PR solve?

Closes #3831

What is changed and how does it work?

Add Env field in BackupSpec, and add logic/ut cases for backup, restore and clean jobs.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Support setting customized envs for backup and restore jobs

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@dragonly you're already a collaborator in bot's repo.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@2b1056e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.1    #3848   +/-   ##
==============================================
  Coverage               ?   51.86%           
==============================================
  Files                  ?      158           
  Lines                  ?    15339           
  Branches               ?        0           
==============================================
  Hits                   ?     7956           
  Misses                 ?     6620           
  Partials               ?      763           
Flag Coverage Δ
unittest 51.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2fad0fa

@ti-chi-bot ti-chi-bot merged commit a8fda12 into pingcap:release-1.1 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants