New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting customized envs for backup and restore jobs (#3833) #3848
Support setting customized envs for backup and restore jobs (#3833) #3848
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@dragonly you're already a collaborator in bot's repo. |
Codecov Report
@@ Coverage Diff @@
## release-1.1 #3848 +/- ##
==============================================
Coverage ? 51.86%
==============================================
Files ? 158
Lines ? 15339
Branches ? 0
==============================================
Hits ? 7956
Misses ? 6620
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2fad0fa
|
cherry-pick #3833 to release-1.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb-operator repo: git pr https://github.com/pingcap/tidb-operator/pull/3848
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Closes #3831
What is changed and how does it work?
Add
Env
field inBackupSpec
, and add logic/ut cases for backup, restore and clean jobs.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.