Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dm-master restarted failed; add scale E2E cases #3972

Merged
merged 8 commits into from
May 12, 2021

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented May 10, 2021

What problem does this PR solve?

What is changed and how does it work?

fix --join arg for DM-master

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix the issue that DM-master may restart failed

@csuzhangxc csuzhangxc requested review from DanielZhangQD and july2993 and removed request for AstroProfundis May 10, 2021 07:40
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #3972 (4b4c1f8) into master (37e0a14) will increase coverage by 4.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3972      +/-   ##
==========================================
+ Coverage   61.99%   66.09%   +4.09%     
==========================================
  Files         173      177       +4     
  Lines       18342    18844     +502     
==========================================
+ Hits        11371    12454    +1083     
+ Misses       5859     5201     -658     
- Partials     1112     1189      +77     
Flag Coverage Δ
e2e 31.13% <ø> (?)
unittest 61.98% <ø> (-0.02%) ⬇️

@csuzhangxc
Copy link
Member Author

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@handlerww
Copy link
Contributor

/run-all-tests

@csuzhangxc csuzhangxc requested review from july2993 and removed request for july2993 May 12, 2021 03:38
Copy link
Contributor

@handlerww handlerww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • handlerww

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@csuzhangxc
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4b4c1f8

@ti-chi-bot ti-chi-bot merged commit dcf7aec into pingcap:master May 12, 2021
@csuzhangxc csuzhangxc deleted the dm-e2e-2 branch May 12, 2021 05:52
mianhk pushed a commit to mianhk/tidb-operator that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dm-master pods may not be restarted
5 participants