Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support-multi-version-dashboard #473

Merged
merged 7 commits into from
May 10, 2019

Conversation

qiffang
Copy link
Contributor

@qiffang qiffang commented May 9, 2019

What problem does this PR solve?

  • Support multi TiDB Cluster dashboard version, default use v2
  • Remove gzip logic because it is too difficult to maintain
    Note
    In Grafana, the symbol "{{" represent a grammar, it conflict with helm grammar, {{ should be replaced by {{{{}}
  • Support multi version binlog dashboard

What is changed and how it works?

Based on the image version to decide dashboard version and binlog version

Check List

Tests

  • V3 TiDB Cluster - PASS
  • V2 TiDB Cluster - PASS
  • Binlog dashboard - PASS

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works for me. In the future, I think it's better to re-package grafana image to follow TiDB version.

@qiffang
Copy link
Contributor Author

qiffang commented May 9, 2019

LGTM, it works for me. In the future, I think it's better to re-package grafana image to follow TiDB version.

Yes, this approach is only a temporary workaround. After a while, we need to discuss a graceful solution.

@tennix tennix merged commit 0c04d39 into pingcap:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants