Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace pdapi to pd sdk #5446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Dec 7, 2023

What problem does this PR solve?

related tikv/pd#7300

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu December 7, 2023 07:18
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from husharp. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 7, 2023
@HuSharp HuSharp removed the request for review from lichunzhu December 7, 2023 07:27
go.mod Outdated
@@ -221,6 +222,8 @@ require (

replace github.com/pingcap/tidb-operator/pkg/apis => ./pkg/apis

replace github.com/tikv/pd/client => github.com/HuSharp/pd/client v0.0.0-20231207064950-c060432d1ad9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to remove this replace and just set the version in L49?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we need to merge pd firstly

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants