ebs br: serial execution of volume backup gc #5452
Conversation
Signed-off-by: BornChanger <dawn_catcher@126.com>
BornChanger
force-pushed
the
ebs_br_serial_gc
branch
from
f3fb83e
to
4b3be4c
Compare
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5452 +/- ##
=======================================
Coverage 61.57% 61.58%
=======================================
Files 230 230
Lines 29156 29166 +10
=======================================
+ Hits 17954 17963 +9
+ Misses 9433 9431 -2
- Partials 1769 1772 +3
|
Signed-off-by: BornChanger <dawn_catcher@126.com>
|
/test-pull-e2e-kind |
Signed-off-by: BornChanger <dawn_catcher@126.com>
|
/run-pull-e2e-kind-br |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
New changes are detected. LGTM label has been removed. |
|
/cherry-pick release-1.5 |
|
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| eg, _ := errgroup.WithContext(context.Background()) | ||
| workerPool := NewWorkerPool(e.concurrency, "delete snapshots") | ||
| for volID := range snapIDMap { | ||
| snapID := snapIDMap[volID] | ||
| eg.Go(func() error { | ||
| workerPool.ApplyOnErrorGroup(eg, func() error { |
There was a problem hiding this comment.
What is the batch size. How many snapshots will be deleted concurrently.
There was a problem hiding this comment.
Its 3 -
What problem does this PR solve?
Closes #5451
What is changed and how does it work?
This PR make the EBS snapshot volume backup GC execute serially. In the single volumebackup, delete snapshots in batches.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.