Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebs br: serial execution of volume backup gc (#5452) #5473

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5452

What problem does this PR solve?

Closes #5451

What is changed and how does it work?

This PR make the EBS snapshot volume backup GC execute serially. In the single volumebackup, delete snapshots in batches.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Signed-off-by: BornChanger <dawn_catcher@126.com>
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #5473 (ea66952) into release-1.5 (29b6292) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #5473   +/-   ##
============================================
  Coverage        61.66%   61.66%           
============================================
  Files              228      228           
  Lines            29096    29106   +10     
============================================
+ Hits             17942    17949    +7     
+ Misses            9394     9393    -1     
- Partials          1760     1764    +4     
Flag Coverage Δ
unittest 61.66% <28.57%> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 2854806 into pingcap:release-1.5 Dec 19, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants