Skip corruption check on last WAL #5596
Conversation
|
|
michaelmdeng
force-pushed
the
mdeng/skip-last-wal-check
branch
from
49eba19
to
c0c0d33
Compare
|
/cc @YuJuncen |
|
@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@michaelmdeng: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5596 +/- ##
==========================================
+ Coverage 61.49% 67.74% +6.25%
==========================================
Files 235 246 +11
Lines 30337 34230 +3893
==========================================
+ Hits 18655 23189 +4534
+ Misses 9813 9138 -675
- Partials 1869 1903 +34
|
|
/retest |
|
/merge |
|
@BornChanger: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/cherry-pick release-1.5 |
|
@BornChanger: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/approve |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, csuzhangxc, WangLe1321, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@BornChanger: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
During EBS snapshot warmup, only check WALs up to the last one for corruption. We expect some corruptions in the last WAL due to race between fsync and EBS snapshot, and we can recover from these scenarios.
Also updates WAL log file pattern since logs can contain variable length log nos.
What is changed and how does it work?
Code changes
Tests
Executed warmup w/ these changes and observe warmup progress normally w/out checking the last WAL
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.