Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip corruption check on last WAL (#5596) #5605

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5596

What problem does this PR solve?

During EBS snapshot warmup, only check WALs up to the last one for corruption. We expect some corruptions in the last WAL due to race between fsync and EBS snapshot, and we can recover from these scenarios.

Also updates WAL log file pattern since logs can contain variable length log nos.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test

Executed warmup w/ these changes and observe warmup progress normally w/out checking the last WAL

  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign linuxgit for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.54%. Comparing base (438a1ed) to head (89358e6).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #5605      +/-   ##
===============================================
- Coverage        61.56%   61.54%   -0.02%     
===============================================
  Files              229      229              
  Lines            29330    29331       +1     
===============================================
- Hits             18056    18051       -5     
- Misses            9495     9498       +3     
- Partials          1779     1782       +3     
Flag Coverage Δ
unittest 61.54% <ø> (-0.02%) ⬇️

@csuzhangxc csuzhangxc merged commit 724031b into pingcap:release-1.5 Apr 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants