diff: get table info before check #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
WangXiangUSTC
changed the title
|
LGTM |
|
Is CI for this repo missing now? PTAL @zhouqiang-cl |
|
/rebuild |
|
any CI testings？ @WangXiangUSTC |
|
I have already request @cwen0 for help @GregoryIan |
|
/run-all-tests |
|
/run-all-tests |
WangXiangUSTC
added a commit
to WangXiangUSTC/tidb-tools
that referenced
this pull request
Feb 25, 2019
WangXiangUSTC
added a commit
that referenced
this pull request
Feb 27, 2019
* diff: get table info before check (#195) * diff: refine code && add unit test for sharding tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
issue: #187
when
ignore-struct-check = trueor some table's struct is not equal, some table's info may be nil.What is changed and how it works?
get all table's info when adjust config in source and target.
Check List
Tests