fixup

pingcap · Apr 30, 2024 · 190e9d3 · 190e9d3
1 parent acba046
commit 190e9d3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/pkg/planner/core/common_unity.go b/pkg/planner/core/common_unity.go
@@ -250,13 +250,11 @@ func getPossibleHints(ctx context.PlanContext, o *UnityOutput) {
 		possibleHints[fmt.Sprintf("hash_join(%v)", strings.Join(hintTableNames, ", "))] = true
 
 		// leading hint
-		for _, t1 := range hintTableNames {
-			for _, t2 := range hintTableNames {
-				if t1 == t2 {
-					continue
-				}
-				possibleHints[fmt.Sprintf("leading(%v, %v)", t1, t2)] = true
+		for t1, t2 := range o.joins {
+			if t1 == t2 {
+				continue
 			}
+			possibleHints[fmt.Sprintf("leading(%v, %v)", t1, t2)] = true
 		}
 	}
 

diff --git a/pkg/planner/core/common_unity_test.go b/pkg/planner/core/common_unity_test.go
@@ -15,7 +15,9 @@ func TestUnity(t *testing.T) {
 	tk.MustExec("use test")
 	tk.MustExec(`create table t1 (a int, b int, c int, key(a))`)
 	tk.MustExec(`create table t2 (a int, b int, c int, key(a))`)
-	formatPrint(tk, `explain format='unity' select * from t1, t2 where t1.a=t2.a`)
+	tk.MustExec(`create table t3 (a int, b int, c int, key(a))`)
+	//formatPrint(tk, `explain format='unity' select * from t1, t2 where t1.a=t2.a`)
+	formatPrint(tk, `explain format='unity' select 1 from t1, t2, t3 where t1.a=t2.a and t2.a=t3.a`)
 }
 
 func formatPrint(tk *testkit.TestKit, sql string) {