address comments

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
pingcap · Sep 27, 2022 · 4fae2bf · 4fae2bf
1 parent d818431
commit 4fae2bf
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/expression/builtin_arithmetic.go b/expression/builtin_arithmetic.go
@@ -117,13 +117,11 @@ func setFlenDecimal4RealOrDecimal(ctx sessionctx.Context, retTp *types.FieldType
 			retTp.SetFlen(types.UnspecifiedLength)
 			return
 		}
-		digitsInt := mathutil.Max(a.GetFlen()-a.GetDecimal(), b.GetFlen()-b.GetDecimal())
-		if isMultiply {
-			digitsInt = a.GetFlen() - a.GetDecimal() + b.GetFlen() - b.GetDecimal()
-		}
 		if isMultiply {
+			digitsInt := a.GetFlen() - a.GetDecimal() + b.GetFlen() - b.GetDecimal()
 			retTp.SetFlenUnderLimit(digitsInt + retTp.GetDecimal())
 		} else {
+			digitsInt := mathutil.Max(a.GetFlen()-a.GetDecimal(), b.GetFlen()-b.GetDecimal())
 			retTp.SetFlenUnderLimit(digitsInt + retTp.GetDecimal() + 1)
 		}
 		if isReal {