address comment

pingcap · Aug 16, 2022 · 5d84575 · 5d84575
1 parent 521190a
commit 5d84575
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/DEPS.bzl b/DEPS.bzl
@@ -3366,8 +3366,8 @@ def go_deps():
         name = "com_github_tikv_client_go_v2",
         build_file_proto_mode = "disable_global",
         importpath = "github.com/tikv/client-go/v2",
-        sum = "h1:tugwRUqH0gYZ0noHr17AVSKxNVd+Jl2BmNqgANeDIok=",
-        version = "v2.0.1-0.20220809034808-2ed2113d1090",
+        sum = "h1:WFR3seA8YtBhDn47YJSW1P1/lwBIXsk0vALnRVuaL/M=",
+        version = "v2.0.1-0.20220815094724-025596b7a20a",
     )
     go_repository(
         name = "com_github_tikv_pd_client",

diff --git a/ddl/schematracker/BUILD.bazel b/ddl/schematracker/BUILD.bazel
@@ -51,7 +51,10 @@ go_test(
         "//parser",
         "//parser/ast",
         "//parser/model",
+        "//sessionctx",
+        "//util/chunk",
         "//util/mock",
+        "//util/sqlexec",
         "@com_github_stretchr_testify//require",
     ],
 )
diff --git a/planner/core/BUILD.bazel b/planner/core/BUILD.bazel
@@ -4,7 +4,6 @@ go_library(
     name = "core",
     srcs = [
         "access_object.go",
-        "cache.go",
         "cacheable_checker.go",
         "collect_column_stats_usage.go",
         "common_plans.go",
@@ -30,6 +29,7 @@ go_library(
         "physical_plans.go",
         "plan.go",
         "plan_cache.go",
+        "plan_cache_utils.go",
         "plan_cost.go",
         "plan_cost_detail.go",
         "plan_stats.go",
@@ -151,7 +151,6 @@ go_test(
     timeout = "short",
     srcs = [
         "binary_plan_test.go",
-        "cache_test.go",
         "cacheable_checker_test.go",
         "cbo_test.go",
         "collect_column_stats_usage_test.go",
@@ -176,6 +175,7 @@ go_test(
         "partition_pruning_test.go",
         "physical_plan_test.go",
         "physical_plan_trace_test.go",
+        "plan_cache_utils_test.go",
         "plan_cost_detail_test.go",
         "plan_cost_test.go",
         "plan_stats_test.go",

diff --git a/session/txninfo/BUILD.bazel b/session/txninfo/BUILD.bazel
@@ -9,9 +9,11 @@ go_library(
     importpath = "github.com/pingcap/tidb/session/txninfo",
     visibility = ["//visibility:public"],
     deps = [
+        "//metrics",
         "//parser/mysql",
         "//types",
         "//util/logutil",
+        "@com_github_prometheus_client_golang//prometheus",
         "@com_github_tikv_client_go_v2//oracle",
         "@org_uber_go_zap//:zap",
     ],