session: fix dml_batch_size doesn't load the global variable (#24710) (…

…#24731)
pingcap · Sep 6, 2021 · a4504d8 · a4504d8
1 parent f0b0834
commit a4504d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/session/session.go b/session/session.go
@@ -2576,6 +2576,7 @@ var builtinGlobalVariable = []string{
 	variable.TiDBMultiStatementMode,
 	variable.TiDBEnableExchangePartition,
 	variable.TiDBAllowFallbackToTiKV,
+	variable.TiDBDMLBatchSize,
 	variable.TiDBEnableOrderedResultMode,
 }
 

diff --git a/session/session_test.go b/session/session_test.go
@@ -4239,6 +4239,16 @@ func (s *testSessionSerialSuite) TestParseWithParams(c *C) {
 	c.Assert(sb.String(), Equals, "SELECT 3")
 }
 
+func (s *testSessionSuite) TestReadDMLBatchSize(c *C) {
+	tk := testkit.NewTestKit(c, s.store)
+	tk.MustExec("set global tidb_dml_batch_size=1000")
+	se, err := session.CreateSession(s.store)
+	c.Assert(err, IsNil)
+	// `select 1` to load the global variables.
+	_, _ = se.Execute(context.TODO(), "select 1")
+	c.Assert(se.GetSessionVars().DMLBatchSize, Equals, 1000)
+}
+
 func (s *testSessionSuite) TestInTxnPSProtoPointGet(c *C) {
 	ctx := context.Background()
 	tk := testkit.NewTestKit(c, s.store)