Skip to content

Commit

Permalink
executor: Fix compact for VARCHAR PK (#51812)
Browse files Browse the repository at this point in the history
fix #51810
  • Loading branch information
breezewish committed Mar 15, 2024
1 parent 1139439 commit ea20982
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/executor/compact_table.go
Expand Up @@ -15,7 +15,6 @@
package executor

import (
"bytes"
"context"
"encoding/hex"
"time"
Expand Down Expand Up @@ -317,7 +316,7 @@ func (task *storeCompactTask) compactOnePhysicalTable(physicalTableID int64) (bo

// Let's send more compact requests, as there are remaining data to compact.
lastEndKey := resp.GetCompactedEndKey()
if len(lastEndKey) == 0 || bytes.Compare(lastEndKey, startKey) <= 0 {
if len(lastEndKey) == 0 {
// The TiFlash server returned an invalid compacted end key.
// This is unexpected...
warn := errors.NewNoStackErrorf("compact on store %s failed: internal error (check logs for details)", task.targetStore.Address)
Expand Down

0 comments on commit ea20982

Please sign in to comment.