Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all Duration builtin functions #12176

Closed
33 tasks done
qw4990 opened this issue Sep 12, 2019 · 16 comments
Closed
33 tasks done

Call For Participation: vectorize all Duration builtin functions #12176

qw4990 opened this issue Sep 12, 2019 · 16 comments
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 12, 2019 •
edited
Loading

This issue is used to trace all vectorized Duration builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.

  • builtinDurationDurationTimeDiffSig
  • builtinTimeTimeTimeDiffSig
  • builtinDurationStringTimeDiffSig
  • builtinStringDurationTimeDiffSig
  • builtinTimeStringTimeDiffSig
  • builtinStringTimeTimeDiffSig
  • builtinStringStringTimeDiffSig
  • builtinNullTimeDiffSig
  • builtinStrToDateDurationSig
  • builtinCurrentTime0ArgSig
  • builtinCurrentTime1ArgSig
  • builtinTimeSig
  • builtinTimeLiteralSig
  • builtinAddTimeDurationNullSig
  • builtinAddDurationAndDurationSig
  • builtinAddDurationAndStringSig
  • builtinMakeTimeSig
  • builtinSecToTimeSig
  • builtinUTCTimeWithoutArgSig
  • builtinUTCTimeWithArgSig
  • builtinCastIntAsDurationSig
  • builtinCastRealAsDurationSig
  • builtinCastDecimalAsDurationSig
  • builtinCastStringAsDurationSig
  • builtinCastTimeAsDurationSig
  • builtinCastDurationAsDurationSig
  • builtinCastJSONAsDurationSig
  • builtinCaseWhenDurationSig
  • builtinIfDurationSig executor: go generate builtin_control_vec.go #12140
  • builtinIfNullDurationSig
  • builtinDurationAnyValueSig
  • builtinNameConstDurationSig
  • builtinCoalesceDurationSig

Prefer to implement them by go generate, see https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit#, and find your interest and take a job.

builtinAddDateStringStringSig
builtinAddDateStringIntSig
builtinAddDateStringRealSig
builtinAddDateStringDecimalSig
builtinAddDateIntStringSig
builtinAddDateIntIntSig
builtinAddDateIntRealSig
builtinAddDateIntDecimalSig
builtinAddDateDatetimeStringSig
builtinAddDateDatetimeIntSig
builtinAddDateDatetimeRealSig
builtinAddDateDatetimeDecimalSig
builtinAddDateDurationStringSig
builtinAddDateDurationIntSig
builtinAddDateDurationRealSig
builtinAddDateDurationDecimalSig

builtinSubDateStringStringSig
builtinSubDateStringIntSig
builtinSubDateStringRealSig
builtinSubDateStringDecimalSig
builtinSubDateIntStringSig
builtinSubDateIntIntSig
builtinSubDateIntRealSig
builtinSubDateIntDecimalSig
builtinSubDateDatetimeStringSig
builtinSubDateDatetimeIntSig
builtinSubDateDatetimeRealSig
builtinSubDateDatetimeDecimalSig
builtinSubDateDurationStringSig
builtinSubDateDurationIntSig
builtinSubDateDurationRealSig
builtinSubDateDurationDecimalSig

builtinSubDateAndDurationSig
builtinSubDateAndStringSig
builtinSubDatetimeAndDurationSig
builtinSubDatetimeAndStringSig
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig
builtinSubStringAndDurationSig
builtinSubStringAndStringSig
builtinSubTimeDateTimeNullSig
builtinSubTimeDurationNullSig
builtinSubTimeStringNullSig
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 12, 2019
@qw4990 qw4990 mentioned this issue Sep 12, 2019
Closed
@tsthght
Copy link
Contributor

tsthght commented Oct 10, 2019 •
edited
Loading

let me fix:
builtinDurationAnyValueSig
builtinNameConstDurationSig
builtinCastDurationAsDurationSig
builtinCastJSONAsDurationSig

This was referenced Oct 10, 2019
Merged
Merged
Merged
Merged
Merged
@mmyj mmyj mentioned this issue Oct 20, 2019
Merged
@mmyj
Copy link
Member

mmyj commented Oct 20, 2019

let me fix it:
builtinCurrentTime0ArgSig
builtinCurrentTime1ArgSig

@mmyj mmyj mentioned this issue Oct 20, 2019
Closed
@mmyj
Copy link
Member

mmyj commented Oct 20, 2019

let me fix it:
builtinDurationDurationTimeDiffSig

@mmyj
Copy link
Member

mmyj commented Oct 20, 2019

let me fix it:
builtinAddDateDurationStringSig

@mmyj
Copy link
Member

mmyj commented Oct 22, 2019 •
edited
Loading

let me fix it:
builtinUTCTimeWithArgSig
builtinUTCTimeWithoutArgSig

@zz-jason zz-jason reopened this Oct 25, 2019
@mmyj mmyj mentioned this issue Oct 31, 2019
Merged
@jiangyuzhao
Copy link
Contributor

let me fix:
builtinSubDurationAndDurationSig

@chenseifer
Copy link

let me fix builtinCastDecimalAsDurationSig

@pingyu
Copy link
Contributor

pingyu commented Nov 16, 2019

Let me fix:
builtinStrToDateDurationSig

@pingyu pingyu mentioned this issue Nov 16, 2019
Merged
@ChiaoTeo
Copy link
Contributor

let me fix :
builtinTimeTimeTimeDiffSig
builtinAddDateDurationIntSig
builtinAddDateDurationDecimalSig
builtinAddDateDurationRealSig
builtinSubDateDurationStringSig

@Thincher
Copy link
Contributor

(●'◡'●) let me fix:
builtinTimeSig
builtinTimeLiteralSig

@js00070
Copy link
Contributor

js00070 commented Nov 18, 2019

let me fix:
builtinValuesDurationSig

@rickif
Copy link

rickif commented Nov 19, 2019

let me fix:
builtinCastRealAsDurationSig

@AerysNan AerysNan mentioned this issue Nov 20, 2019
Merged
@SilvaXiang
Copy link
Contributor

let me fix builtinSubTimeDurationNullSig

@SilvaXiang SilvaXiang mentioned this issue Nov 23, 2019
Closed
@SilvaXiang
Copy link
Contributor

let me fix
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig

This was referenced Nov 24, 2019
Closed
Closed
@SunRunAway
Copy link
Contributor

@SilvaXiang builtinSubXXXAndYYYSig may be resolved by go generate, could you take a look at https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit#

@SilvaXiang SilvaXiang mentioned this issue Nov 27, 2019
Merged
@tongxing2019 tongxing2019 mentioned this issue Nov 27, 2019
Merged
This was referenced Nov 28, 2019
Closed
Merged
@tangwz tangwz mentioned this issue Nov 29, 2019
Merged
@hsqlu hsqlu mentioned this issue Nov 29, 2019
Merged
@tangwz tangwz mentioned this issue Dec 4, 2019
Merged
@francis0407 francis0407 mentioned this issue Dec 8, 2019
Merged
@SilvaXiang SilvaXiang mentioned this issue Dec 14, 2019
Closed
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 6, 2020

Close due to finish.

@qw4990 qw4990 closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests