Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in TestSingleStatementRollback #12396

Closed
zz-jason opened this issue Sep 25, 2019 · 0 comments · Fixed by #12398
Closed

data race in TestSingleStatementRollback #12396

zz-jason opened this issue Sep 25, 2019 · 0 comments · Fixed by #12398
Assignees
Labels
type/bug This issue is a bug.

Comments

@zz-jason
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

discovered at https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/7994/pipeline/

  1. What did you expect to see?

N/A

  1. What did you see instead?
[2019-09-25T11:49:43.766Z] ==================
[2019-09-25T11:49:43.766Z] WARNING: DATA RACE
[2019-09-25T11:49:43.766Z] Read at 0x00c001bc8078 by goroutine 200:
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*ttlManager).keepAlive()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/2pc.go:343 +0x6a4
[2019-09-25T11:49:43.766Z] 
[2019-09-25T11:49:43.766Z] Previous write at 0x00c001bc8078 by goroutine 208:
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*tikvTxn).LockKeys()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/txn.go:417 +0xe47
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session.(*TxnState).LockKeys()
[2019-09-25T11:49:43.766Z]       <autogenerated>:1 +0xb1
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handlePessimisticDML()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:560 +0x318
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:399 +0x102
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:369 +0x31f
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session.runStmt()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:239 +0x1f9
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session.(*session).executeStatement()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1022 +0x203
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session.(*session).execute()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1126 +0xaeb
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session.(*session).Execute()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1061 +0xd4
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).Exec()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:144 +0x103
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustExec()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:182 +0x91
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session_test.(*testPessimisticSuite).TestSingleStatementRollback.func1()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/pessimistic_test.go:218 +0x168
[2019-09-25T11:49:43.766Z] 
[2019-09-25T11:49:43.766Z] Goroutine 200 (running) created at:
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*ttlManager).run()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/2pc.go:614 +0x80
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*twoPhaseCommitter).pessimisticLockSingleBatch()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/2pc.go:717 +0x110f
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*twoPhaseCommitter).pessimisticLockSingleBatch-fm()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/2pc.go:670 +0xae
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/store/tikv.(*batchExecutor).startWorker.func1()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/tikv/2pc.go:1212 +0x3c5
[2019-09-25T11:49:43.766Z] 
[2019-09-25T11:49:43.766Z] Goroutine 208 (running) created at:
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session_test.(*testPessimisticSuite).TestSingleStatementRollback()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/pessimistic_test.go:214 +0x57d
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session_test.(*testPessimisticSuite).TestSingleStatementRollback()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/pessimistic_test.go:202 +0x285
[2019-09-25T11:49:43.766Z]   github.com/pingcap/tidb/session_test.(*testPessimisticSuite).TestSingleStatementRollback()
[2019-09-25T11:49:43.766Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/pessimistic_test.go:201 +0x24e
[2019-09-25T11:49:43.766Z]   runtime.call32()
[2019-09-25T11:49:43.766Z]       /usr/local/go/src/runtime/asm_amd64.s:519 +0x3a
[2019-09-25T11:49:43.766Z]   reflect.Value.Call()
[2019-09-25T11:49:43.766Z]       /usr/local/go/src/reflect/value.go:308 +0xc0
[2019-09-25T11:49:43.766Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2019-09-25T11:49:43.767Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20190102082844-67f458068fc8/check.go:836 +0x9fc
[2019-09-25T11:49:43.767Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2019-09-25T11:49:43.767Z]       /home/jenkins/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20190102082844-67f458068fc8/check.go:730 +0xb7
[2019-09-25T11:49:43.767Z] ==================
  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

#12336

@zz-jason zz-jason added the type/bug This issue is a bug. label Sep 25, 2019
@lysu lysu removed their assignment Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants