Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for ddl/stat_test.go #29114

Closed
Tracked by #27180
tisonkun opened this issue Oct 26, 2021 · 7 comments · Fixed by #31313
Closed
Tracked by #27180

migrate test-infra to testify for ddl/stat_test.go #29114

tisonkun opened this issue Oct 26, 2021 · 7 comments · Fixed by #31313
Assignees
@GatorMao @JayLZhou
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Oct 26, 2021
Closed
34 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 26, 2021
@JayLZhou
Copy link
Contributor

/assign

@JayLZhou
Copy link
Contributor

@tisonkun i notice stat_test.go use testGetTable and testCreateSchema etc. functions. These functions have a very strong coupling relationship with other tests in the ddl package

@JayLZhou
Copy link
Contributor

@tisonkun The migration of a single test file is not very easy to do. Why don't I replace all of them with testing and remove the previous tests using Check

@tisonkun
Copy link
Contributor Author

@jayl-zxl you can always take multiple issues at the same time.

@JayLZhou
Copy link
Contributor

@tisonkun i see ..

@tisonkun
Copy link
Contributor Author

@jayl-zxl I'm ok if you'd like to just rewrite the tests. But maybe you should reach a consensus with ones of @tiancaiamao @zimulala @djshow832 .

Just create a new issue and close these migration tests if that one accepted and resolved.

@GatorMao
Copy link
Contributor

GatorMao commented Jan 5, 2022

/assign

@GatorMao GatorMao mentioned this issue Jan 8, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jan 20, 2022
@GatorMao
ddl, tools, util: migrate pingcap check to testify. (#31313)
06a4dfa 
close #28630, close #28631, close #28638, close #28639, close #29104, close #29108, close #29109, close #29111, close #29114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GatorMao GatorMao

@JayLZhou JayLZhou

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl, tools, util: migrate pingcap check to testify. GatorMao/tidb
3 participants
@GatorMao @tisonkun @JayLZhou