Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine only-full-group-by checker #29766

Closed
xuyifangreeneyes opened this issue Nov 15, 2021 · 6 comments · Fixed by #33875
Closed

Refine only-full-group-by checker #29766

xuyifangreeneyes opened this issue Nov 15, 2021 · 6 comments · Fixed by #33875
Assignees

Comments

@xuyifangreeneyes
Copy link
Contributor

xuyifangreeneyes commented Nov 15, 2021

Enhancement

TiDB's only-full-group-by checker is not so compatible with MySQL. The incompatibility brings trouble to users and the current workaround is to remove ONLY_FULL_GROUP_BY from sql_mode. We need to make only-full-group-by checker more compatible with MySQL.

Here are the issues related to only-full-group-by checker:

One cause for some issues is that only-full-group-by checker is not smart enough to infer some functional dependency(See #14580 for details).

@xuyifangreeneyes
Copy link
Contributor Author

/label planner

@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: The label(s) planner cannot be applied. These labels are supported: challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, needs-cherry-pick-5.3, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, backport-4.0.14, backport-4.0.15, backport-5.0.3, backport-5.0.4, backport-5.1.0, backport-5.1.1, backport-5.1.2.

In response to this:

/label planner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuyifangreeneyes
Copy link
Contributor Author

/planner

@xuyifangreeneyes
Copy link
Contributor Author

/sig planner

@winoros
Copy link
Member

winoros commented Dec 15, 2021

The design doc:
https://pingcap.feishu.cn/docs/doccndyrRWfcGALhjcyVhOrxWYd

@winoros
Copy link
Member

winoros commented Dec 15, 2021

Splitted working items

  • Introducing the basic structure for the functional dependency. @AilinKid
  • Implementing the basic inserting logic of strict functional dependency. @AilinKid
  • Implementing the basic inserting logic of strict equiv constraint. @AilinKid
  • Implementing the basic inserting logic of lax functional dependency. @AilinKid
  • Implementing the maintain for DataSource. @AilinKid
  • Implementing the maintain for Selection. @AilinKid
  • Implementing the maintain for inner join. @winoros
  • Implementing the maintain for outer join. @winoros
  • Implementing the maintain for Aggregation. @AilinKid
  • Implementing the maintain for Projection. @AilinKid
  • Implementing the maintain for Union/Except/Intersect.
  • Implementing the maintain for View/CTE.
  • Integrated with the plan builder. @AilinKid
  • Testing against the SQL mode. @AilinKid@winoros

@winoros winoros self-assigned this Dec 15, 2021
ti-chi-bot pushed a commit that referenced this issue May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants