Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record new_collation setting in br backup and compare new_collation during restore #33422

Closed
fubinzh opened this issue Mar 25, 2022 · 3 comments · Fixed by #33500 or pingcap/kvproto#887 · May be fixed by #33593
Closed

Record new_collation setting in br backup and compare new_collation during restore #33422

fubinzh opened this issue Mar 25, 2022 · 3 comments · Fixed by #33500 or pingcap/kvproto#887 · May be fixed by #33593
Assignees
@joccau
Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 component/br This issue is related to BR of TiDB. severity/major type/bug This issue is a bug.

Comments

@fubinzh
Copy link

fubinzh commented Mar 25, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  • do br backup of a tidb cluster with new_collation disabled
  • restore the backup to a cluster with new_collation enabled

2. What did you expect to see? (Required)

  • Restore should check new_collation compatibility and fail directly if new_collation setting of target cluster is different from that in the backup.
    To archive this, we need to:
    a. During br backup, we can record new_collation setting of the tidb cluster.
    b. When we restore to a target cluster, br can compare new_collation setting of the target cluster with that in the backup, and prevent user from restore if they are not the same.

3. What did you see instead (Required)

Currently br restored data may have checksum and index error if source tidb and target tidb has different new_collation settings, and we reply on user to make sure they are the same, which is not user friendly.

4. What is your TiDB version? (Required)

BR 6.0.0
@fubinzh fubinzh added type/bug This issue is a bug. severity/major component/br This issue is related to BR of TiDB. labels Mar 25, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 labels Mar 25, 2022
@joccau joccau mentioned this issue Mar 28, 2022
Merged
12 tasks
@3pointer 3pointer added affects-5.4 This bug affects 5.4.x versions. and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. labels Mar 28, 2022
@ti-srebot ti-srebot mentioned this issue Mar 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 28, 2022
@ti-srebot
br: Fix new collaction enable check (#33500) (#33521)
d8e838e 
close #33422
This was referenced Mar 29, 2022
Merged
Merged
Closed
@JmPotato JmPotato mentioned this issue Mar 30, 2022
Closed
@joccau joccau mentioned this issue Mar 30, 2022
Open
12 tasks
@mayjiang0203 mayjiang0203 mentioned this issue Mar 31, 2022
Closed
This was referenced Apr 13, 2022
Merged
Merged
@joccau
Copy link
Member

joccau commented Apr 17, 2022

/affects-5.2

@joccau
Copy link
Member

joccau commented Apr 17, 2022

/label affects-5.2

@ti-chi-bot ti-chi-bot added the affects-5.2 This bug affects 5.2.x versions. label Apr 17, 2022
@joccau
Copy link
Member

joccau commented Apr 17, 2022

/label affects-5.3

@ti-chi-bot ti-chi-bot added the affects-5.3 This bug affects 5.3.x versions. label Apr 17, 2022
ti-chi-bot pushed a commit that referenced this issue Apr 28, 2022
@ti-srebot
br: Fix new collaction enable check (#33500) (#33532)
95fc56b 
close #33422
@joccau joccau mentioned this issue Jun 14, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 16, 2022
@ti-srebot
br: Fix new collaction enable check (#33500) (#33533)
bf81222 
close #33422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joccau joccau

Labels
affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.0 component/br This issue is related to BR of TiDB. severity/major type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
5 participants
@jebter @3pointer @fubinzh @joccau @ti-chi-bot