Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove intersecting regions in the region cache when updating regions #37141

Closed
sticnarf opened this issue Aug 16, 2022 · 0 comments · Fixed by #37142
Closed

Remove intersecting regions in the region cache when updating regions #37141

sticnarf opened this issue Aug 16, 2022 · 0 comments · Fixed by #37142
Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 type/enhancement

Comments

@sticnarf
Copy link
Contributor

Enhancement

When many regions are merged together, the stale regions won't be removed from the cache. This may waste CPU in b-tree searching or use incorrect region info to access TiKV.

See tikv/client-go#565 for details
@sticnarf sticnarf mentioned this issue Aug 16, 2022
Merged
1 task
ti-chi-bot pushed a commit that referenced this issue Aug 16, 2022
@sticnarf
*: update client-go to optimize region cache after merging many regio…
d226909 
…ns (#37142)

close #37141
@sticnarf sticnarf mentioned this issue Sep 14, 2022
Merged
12 tasks
@sticnarf sticnarf added affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 labels Sep 14, 2022
@sticnarf sticnarf mentioned this issue Oct 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 11, 2022
@sticnarf
store/tikv: clear intersecting regions in the cache when inserting a …
c3f526f 
…region (#38388)

close #37141
ti-chi-bot pushed a commit that referenced this issue Oct 12, 2022
@sticnarf
store/tikv: clear intersecting regions in the cache when inserting a …
3ab8745 
…region (#37809)

close #37141
@sticnarf sticnarf mentioned this issue Oct 12, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Oct 12, 2022
@sticnarf
*: update client-go (tidb-6.1) (#38414)
0e9823d 
close #37141
@cfzjywxk cfzjywxk mentioned this issue Oct 19, 2022
Merged
14 tasks
@sticnarf sticnarf mentioned this issue Nov 8, 2022
Merged
4 tasks
ti-chi-bot pushed a commit that referenced this issue Nov 8, 2022
@sticnarf
*: update client-go for v5.3.4 (#38964)
3ba592f 
close #37141
@sticnarf sticnarf mentioned this issue Jan 17, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update client-go to optimize region cache after merging many regions sticnarf/tidb
1 participant
@sticnarf