Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: proxy protocol fallback feature will return header read timeout error when underlay connection read got error #43205

Closed
blacktear23 opened this issue Apr 19, 2023 · 0 comments · Fixed by #43189
Closed

server: proxy protocol fallback feature will return header read timeout error when underlay connection read got error #43205

blacktear23 opened this issue Apr 19, 2023 · 0 comments · Fixed by #43189
Labels
affects-6.1 affects-6.5 affects-7.1 severity/major sig/sql-infra SIG: SQL Infra type/bug This issue is a bug.

Comments

@blacktear23
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

server: proxy protocol fallback feature will return header read timeout error when underlay connection read got error

1. Minimal reproduce step (Required)

start tidb with fallbackable=true
echo -ne "" | nc  localhost 4000 &> /dev/null

[2023/04/18 17:02:37.376 +08:00] [WARN] [server.go:612] ["Server.onConn handshake"] [conn=2199023255981] [error="Header read timeout"] ["remote addr"="[::1]:60100"]

2. What did you expect to see? (Required)

the error that conn.Read actually returned.

3. What did you see instead (Required)

got Header read timeout error.

4. What is your TiDB version? (Required)

master
@blacktear23 blacktear23 added the type/bug This issue is a bug. label Apr 19, 2023
@blacktear23 blacktear23 mentioned this issue Apr 19, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Apr 20, 2023
@hawkingrei hawkingrei removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. labels Apr 21, 2023
ti-chi-bot pushed a commit that referenced this issue Apr 22, 2023
@blacktear23
*: Update go-proxyprotocol version to fix some corner case (#43189)
8aa7ae2 
close #43205
This was referenced Apr 22, 2023
Merged
Merged
Closed
ti-chi-bot bot pushed a commit that referenced this issue May 29, 2023
@ti-chi-bot
*: Update go-proxyprotocol version to fix some corner case (#43189) (#…
bcb8e79 
…43306)

close #43205
ti-chi-bot bot pushed a commit that referenced this issue Jun 1, 2023
@ti-chi-bot
*: Update go-proxyprotocol version to fix some corner case (#43189) (#…
efc75c0 
…43307)

close #43205
@tiancaiamao tiancaiamao mentioned this issue Jul 18, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 severity/major sig/sql-infra SIG: SQL Infra type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Update go-proxyprotocol version to fix some corner case blacktear23/tidb
4 participants
@blacktear23 @hawkingrei @jebter @ti-chi-bot