Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: the error message of fine-grained backup is misleading #43236

Closed
YuJuncen opened this issue Apr 20, 2023 · 0 comments · Fixed by #43252
Closed

backup: the error message of fine-grained backup is misleading #43236

YuJuncen opened this issue Apr 20, 2023 · 0 comments · Fixed by #43252
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 component/br This issue is related to BR of TiDB. severity/moderate type/bug This issue is a bug.

Comments

@YuJuncen
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Start a backup, and then inject some errors, (for example, make PD always provide stale information.), and begin backup.

2. What did you expect to see? (Required)

The backup should fail at the "fine-grained backup" stage, and reporting some meaningful error message.

3. What did you see instead (Required)

It reports "resolve lock timeout".

4. What is your TiDB version? (Required)

v6.1.2, however all versions of BR may have this problem.
@YuJuncen YuJuncen added type/bug This issue is a bug. severity/moderate labels Apr 20, 2023
@jebter jebter added the component/br This issue is related to BR of TiDB. label Apr 20, 2023
@YuJuncen YuJuncen mentioned this issue Apr 20, 2023
Merged
4 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 21, 2023
@YuJuncen
backup: fix retry of fine-grained backup (#43252)
1a94e5d 
close #43236
This was referenced Apr 22, 2023
Merged
Closed
Open
Merged
@YuJuncen YuJuncen mentioned this issue Apr 23, 2023
Merged
4 tasks
@jebter jebter added affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 labels Apr 28, 2023
@ti-chi-bot ti-chi-bot mentioned this issue Apr 28, 2023
Merged
4 tasks
ti-chi-bot bot pushed a commit that referenced this issue May 8, 2023
@ti-chi-bot
backup: fix retry of fine-grained backup (#43252) (#43487)
d062cdd 
close #43236
YuJuncen added a commit to ti-chi-bot/tidb that referenced this issue May 23, 2023
@YuJuncen
backup: fix retry of fine-grained backup (pingcap#43252)
c235f7e 
close pingcap#43236
ti-chi-bot bot pushed a commit that referenced this issue May 23, 2023
@ti-chi-bot
backup: fix retry of fine-grained backup (#43252) (#43305)
0457615 
close #43236
@3pointer 3pointer mentioned this issue Jun 9, 2023
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 30, 2023
@ti-chi-bot
backup: fix retry of fine-grained backup (#43252) (#43302)
efc5387 
close #43236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 component/br This issue is related to BR of TiDB. severity/moderate type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backup: fix retry of fine-grained backup YuJuncen/tidb
2 participants
@jebter @YuJuncen