Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make normalization more aggressive #43409

Closed
jackysp opened this issue Apr 25, 2023 · 1 comment · Fixed by #43410
Closed

Make normalization more aggressive #43409

jackysp opened this issue Apr 25, 2023 · 1 comment · Fixed by #43410

Comments

@jackysp
Copy link
Member

jackysp commented Apr 25, 2023

Enhancement

If, for example, the digest of insert into t values (1, 1), (2,2) is different from that of insert into t values (1, 1), then they will be treated as different statements in the statements summary. This can easily lead to meaningful SQL being eliminated. We should make the digests of trail inserts with different row counts the same.

@xhebox
Copy link
Contributor

xhebox commented Apr 27, 2023

I've tested a little bit, this does fixed digest_test, but did not improve #33559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants