Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteConflictError does not hide field specified by redact positions #43485

Closed
ekexium opened this issue Apr 28, 2023 · 0 comments · Fixed by #43486
Closed

WriteConflictError does not hide field specified by redact positions #43485

ekexium opened this issue Apr 28, 2023 · 0 comments · Fixed by #43486
Labels
affects-6.5 affects-6.6 affects-7.0 affects-7.1 severity/major type/bug This issue is a bug.

Comments

@ekexium
Copy link
Contributor

ekexium commented Apr 28, 2023

Bug Report

Sensitive content(keys) in Write Conflict errors can be printed as plain text in logs, instead of replaced by "?".
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Apr 28, 2023
@ekexium ekexium removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Apr 28, 2023
@ekexium ekexium mentioned this issue Apr 28, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 28, 2023
@ekexium
log: let Write Conflict error message respect redact setting (#43486)
ba3ce86 
close #43485
This was referenced Apr 28, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 6, 2023
@ti-chi-bot
log: let Write Conflict error message respect redact setting (#43486) (…
3fa4fb9 
…#43489)

close #43485
ti-chi-bot bot pushed a commit that referenced this issue May 10, 2023
@ti-chi-bot
log: let Write Conflict error message respect redact setting (#43486) (…
8e91c44 
…#43490)

close #43485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 affects-6.6 affects-7.0 affects-7.1 severity/major type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: let Write Conflict error message respect redact setting ekexium/tidb
1 participant
@ekexium