Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessFollower will try to access unreachable leader peers #46198

Closed
zyguan opened this issue Aug 17, 2023 · 2 comments
Closed

AccessFollower will try to access unreachable leader peers #46198

zyguan opened this issue Aug 17, 2023 · 2 comments
Labels
affects-6.5 may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 severity/major sig/transaction SIG:Transaction type/bug This issue is a bug.

Comments

@zyguan
Copy link
Contributor

zyguan commented Aug 17, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run a stale read workload and inject network partition between two zones.

2. What did you expect to see? (Required)

KV client should never try to access unreachable peers.

3. What did you see instead (Required)

accessFollower may choose an unreachable leader peer as the target after fallback from data-not-ready error, which leads to unexpected long-tail queries.

2023-08-17_173808

4. What is your TiDB version? (Required)

release-6.5
@zyguan zyguan added the type/bug This issue is a bug. label Aug 17, 2023
zyguan added a commit to zyguan/tidb that referenced this issue Aug 17, 2023
@zyguan
*: bump client-go to fix pingcap#46198
b58b118 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 labels Aug 17, 2023
@zyguan zyguan mentioned this issue Aug 17, 2023
Merged
12 tasks
@cfzjywxk cfzjywxk added the sig/transaction SIG:Transaction label Aug 17, 2023
ti-chi-bot bot pushed a commit that referenced this issue Aug 17, 2023
@zyguan
*: bump client-go to fix #46198 (#46199)
24f435b 
close #46198
@cfzjywxk cfzjywxk mentioned this issue Sep 15, 2023
Merged
18 tasks
@cfzjywxk
Copy link
Contributor

@zyguan
Should it be closed as it's fixed?

@zyguan
Copy link
Contributor Author

zyguan commented Oct 12, 2023

@zyguan Should it be closed as it's fixed?

Yes, fixed by tikv/client-go#971

@zyguan zyguan closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.1 severity/major sig/transaction SIG:Transaction type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfzjywxk @zyguan