Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

threshold of gctuner need to recalculate when ServerMemoryLimit is updated #48180

Closed
disksing opened this issue Nov 1, 2023 · 0 comments · Fixed by #51197
Closed

threshold of gctuner need to recalculate when ServerMemoryLimit is updated #48180

disksing opened this issue Nov 1, 2023 · 0 comments · Fixed by #51197
Assignees
@hawkingrei
Labels
affects-6.5 affects-7.1 affects-7.5 severity/major sig/sql-infra SIG: SQL Infra type/bug This issue is a bug.

Comments

@disksing
Copy link
Contributor

disksing commented Nov 1, 2023

Bug Report

1. Minimal reproduce step (Required)

update global variable tidb_server_memory_limit

2. What did you expect to see? (Required)

threshold of gctuner should be updated according to new value of memory limit

3. What did you see instead (Required)

threshold of gctuner is not updated (because it is only updated when we update tidb_gogc_tuner_threshold)

4. What is your TiDB version? (Required)

master
@disksing disksing added the type/bug This issue is a bug. label Nov 1, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 labels Nov 2, 2023
@hawkingrei hawkingrei mentioned this issue Feb 20, 2024
Merged
13 tasks
@hawkingrei hawkingrei removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Feb 20, 2024
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@hawkingrei
*: recalculate the threshold of gctuner when ServerMemoryLimit is upd…
e35cf1d 
…ated (#51197)

close #48180
This was referenced Feb 21, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@ti-chi-bot
*: recalculate the threshold of gctuner when ServerMemoryLimit is upd…
1fa7b21 
…ated (#51197) (#51213)

close #48180
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@ti-chi-bot
*: recalculate the threshold of gctuner when ServerMemoryLimit is upd…
e33ccdc 
…ated (#51197) (#51214)

close #48180
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@ti-chi-bot
*: recalculate the threshold of gctuner when ServerMemoryLimit is upd…
08498f0 
…ated (#51197) (#51215)

close #48180
@tiancaiamao tiancaiamao mentioned this issue Mar 5, 2024
Merged
18 tasks
@bb7133 bb7133 mentioned this issue Mar 27, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkingrei hawkingrei

Labels
affects-6.5 affects-7.1 affects-7.5 severity/major sig/sql-infra SIG: SQL Infra type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: recalculate the threshold of gctuner when ServerMemoryLimit is updated hawkingrei/tidb
3 participants
@hawkingrei @jebter @disksing