Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: remove all codes of telemetry #49939

Closed
bb7133 opened this issue Dec 29, 2023 · 1 comment · Fixed by #51202
Closed

RFC: remove all codes of telemetry #49939

bb7133 opened this issue Dec 29, 2023 · 1 comment · Fixed by #51202
Labels
type/enhancement

Comments

@bb7133
Copy link
Member

bb7133 commented Dec 29, 2023

Enhancement

After #41336, PingCAP(the company behind TiDB) stopped collecting telemetry data from all running clusters, and I don't think any other organization or user is using this feature. So IMHO it's time to clean up all the codes and turn EnableTelemetry to a deprecated configuration(configurable but never work).

What do we get from it:

  • A (slightly) higher overall code coverage, the code coverage of telemetry pkg is only 42%.
  • Easier maintenance of the codebase, for there'll be fewer codes.

If you have any concerns about this, feel free to leave your comments in this issue.
@bb7133 bb7133 pinned this issue Dec 29, 2023
@Defined2014
Copy link
Contributor

Agree!

@bb7133 bb7133 mentioned this issue Feb 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 22, 2024
@bb7133
telemetry: remove the codes of Telemetry (#51202)
3d1708f 
close #49939
@hawkingrei hawkingrei unpinned this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

telemetry: remove the codes of Telemetry bb7133/tidb
2 participants
@bb7133 @Defined2014