Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionInfo structs/variables are used for PartitionDefinitions and causing confusion when reading the code. #49988

Closed
mjonss opened this issue Jan 2, 2024 · 0 comments · Fixed by #49989
Closed

PartitionInfo structs/variables are used for PartitionDefinitions and causing confusion when reading the code. #49988

mjonss opened this issue Jan 2, 2024 · 0 comments · Fixed by #49989
Labels
sig/sql-infra SIG: SQL Infra type/enhancement

Comments

@mjonss
Copy link
Contributor

mjonss commented Jan 2, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

See here, where:

partInfo         *model.PartitionDefinition

2. What did you expect to see? (Required)

Either partition, partitionDef or something else, since model.PartitionInfo is a different struct, containing the full partition definitions.

3. What did you see instead (Required)

partInfo referring to a PartitionDefinition.

4. What is your TiDB version? (Required)

Current master, 999f599
@mjonss mjonss added the type/bug This issue is a bug. label Jan 2, 2024
@mjonss mjonss mentioned this issue Jan 2, 2024
Merged
12 tasks
@jebter jebter added the sig/sql-infra SIG: SQL Infra label Jan 3, 2024
@Defined2014 Defined2014 added type/enhancement and removed type/bug This issue is a bug. labels Jan 3, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 6, 2024
@mjonss
*: renaming variables/structs to improve readability / decrease confu…
9b0fd9e 
…sion (#49989)

close #49988
AilinKid pushed a commit to AilinKid/tidb that referenced this issue Jan 17, 2024
@mjonss @AilinKid
*: renaming variables/structs to improve readability / decrease confu…
bfecca6 
…sion (pingcap#49989)

close pingcap#49988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: renaming variables/structs to improve readability / decrease confusion mjonss/tidb
3 participants
@jebter @mjonss @Defined2014