Remove wait_apply stage in disk snapshot restore
#50312
Labels
Comments
5 tasks
This was referenced Jan 16, 2024
YuJuncen
added a commit
to ti-chi-bot/tidb
that referenced
this issue
Feb 20, 2024
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this issue
Mar 5, 2024
…pingcap#36) close pingcap#50312, close pingcap#50315 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement
The
wait_applystage in disk snapshot restore was used for preparing "physical" flashback, which delete all entries committed after the flashback TS directly in each peers underlying storage (RocksDB), without any synchronization by raft.For keeping the consistency of the raft state machine, we must wait all peers' state machine go to the same state.
But for now, the flashback implementation should be the same as
FLASHBACK TABLESQL statement, which will "logically" delete the keys needed to be flashed back by committing new writes with raft. Hence it is no need to wait all peers(but only leaders) apply to last index.We can remove the useless step. Given it have brought other bugs, like make backup stuck if there are some stale peers.
The text was updated successfully, but these errors were encountered: