Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: incorrect datatime value when sql-mode is NO_ZERO_IN_DATE #50757

Closed
GMHDBJD opened this issue Jan 26, 2024 · 1 comment · Fixed by #51201
Closed

lightning: incorrect datatime value when sql-mode is NO_ZERO_IN_DATE #50757

GMHDBJD opened this issue Jan 26, 2024 · 1 comment · Fixed by #51201
Assignees
@GMHDBJD
Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 affects-7.5 component/lightning This issue is related to Lightning of TiDB. found/customer Customers have encountered this bug. severity/minor type/bug This issue is a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jan 26, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

sql-mode = 'STRICT_TRANS_TABLES,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,IGNORE_SPACE'
$ tiup tidb-lightning:v7.1.3 -config a.toml -check-requirements=0
Starting component `tidb-lightning`: /home/tidb/.tiup/components/tidb-lightning/v7.1.3/tidb-lightning -config a.toml -check-requirements=0
Verbose debug logs will be written to tidb-lightning0125-01.logtidb lightning encountered error: [Lightning:Restore:ErrEncodeKV]encode kv error in file test.share_inventory_range_bak.0000000010000.sql:0 at offset 1005: failed to cast value as datetime BINARY for column `end_time` (#17): [types:1292]Incorrect datetime value: '1990-01-00 00:00:00'

2. What did you expect to see? (Required)

load data succeed

3. What did you see instead (Required)

[types:1292]Incorrect datetime value: '1990-01-00 00:00:00'

4. What is your TiDB version? (Required)
@GMHDBJD GMHDBJD added the type/bug This issue is a bug. label Jan 26, 2024
@jebter jebter added the component/lightning This issue is related to Lightning of TiDB. label Jan 26, 2024
@seiya-annie seiya-annie added affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 affects-7.5 labels Feb 4, 2024
@GMHDBJD GMHDBJD mentioned this issue Feb 20, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@GMHDBJD
importinto/lightning: fix incorrect datatime value for zero date (#51201
4c76b12 
)

close #50757
@ti-chi-bot ti-chi-bot mentioned this issue Feb 21, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 21, 2024
@ti-chi-bot
importinto/lightning: fix incorrect datatime value for zero date (#51201
4e85c14 
) (#51221)

close #50757
@ti-chi-bot ti-chi-bot mentioned this issue Feb 21, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 28, 2024
@ti-chi-bot
importinto/lightning: fix incorrect datatime value for zero date (#51201
7d26c5d 
) (#51226)

close #50757
@Benjamin2037 Benjamin2037 mentioned this issue Mar 21, 2024
Merged
18 tasks
This was referenced Mar 25, 2024
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 29, 2024
@ti-chi-bot
importinto/lightning: fix incorrect datatime value for zero date (#51201
e52ef6f 
) (#51226) (#52066)

close #50757
@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the found/customer Customers have encountered this bug. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GMHDBJD GMHDBJD

Labels
affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. affects-5.3 This bug affects 5.3.x versions. affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.5 affects-7.1 affects-7.5 component/lightning This issue is related to Lightning of TiDB. found/customer Customers have encountered this bug. severity/minor type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importinto/lightning: fix incorrect datatime value for zero date GMHDBJD/tidb
3 participants
@jebter @GMHDBJD @seiya-annie