Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max_prepared_stmt_count work #8133

Closed
winoros opened this issue Nov 1, 2018 · 0 comments · Fixed by #8405
Closed

Make max_prepared_stmt_count work #8133

winoros opened this issue Nov 1, 2018 · 0 comments · Fixed by #8405
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility

Comments

@winoros
Copy link
Member

winoros commented Nov 1, 2018

Feature Request

Is your feature request related to a problem? Please describe:

max_prepared_stmt_count is a variable ported from mysql.

It controls that how many PREPARE statement tidb can store at one time. It can be used in environments where there is the potential for denial-of-service attacks based on running the server out of memory by preparing huge numbers of statements.

It can disable the prepare statement if we set it to zero.

Currently we have ported it. But not actually make it work.

Teachability, Documentation, Adoption, Migration Strategy:

https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_prepared_stmt_count
@winoros winoros added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 1, 2018
@winoros winoros mentioned this issue Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: add preparedStmt metric and add limit to max prepareStmt
1 participant
@winoros