Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: control Chunk size for Selection&Projection #10110

Merged
merged 2 commits into from Apr 11, 2019
Merged

executor: control Chunk size for Selection&Projection #10110

merged 2 commits into from Apr 11, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 10, 2019

cherry-pick for #9398

@qw4990 qw4990 requested review from lysu and zz-jason April 10, 2019 13:00
zz-jason
zz-jason reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

lysu
lysu previously approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2019
@qw4990 qw4990 force-pushed the release-2.1_chunk_sel_proj branch from 1ae60c9 to 55351a7 Compare April 11, 2019 04:41
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

3 similar comments
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 11, 2019

After git rebase, all checks have passed, PTAL~ @zz-jason @lysu

@ngaut ngaut merged commit e5cfa51 into pingcap:release-2.1 Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@winoros winoros winoros approved these changes

@lysu lysu lysu left review comments

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qw4990 @lysu @zz-jason @winoros @ngaut