Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix the wrong order by pk desc result and some corner cases for unsigned pk (#10179) #10209

Merged
merged 4 commits into from Apr 22, 2019
Merged

executor: fix the wrong order by pk desc result and some corner cases for unsigned pk (#10179) #10209

merged 4 commits into from Apr 22, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 22, 2019

What problem does this PR solve?

Cherry-pick #10179

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note

@winoros winoros added type/bug-fix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Apr 22, 2019
XuHuaiyu
XuHuaiyu approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 22, 2019
@zz-jason zz-jason merged commit 377c00d into pingcap:release-2.1 Apr 22, 2019
@winoros winoros deleted the pick branch May 14, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@alivxxx alivxxx Awaiting requested review from alivxxx

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@winoros @zz-jason @XuHuaiyu @ngaut